Allow Pipeline and TransformedTargetModel to support feature importances
#963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #963 +/- ##
==========================================
+ Coverage 88.01% 88.07% +0.05%
==========================================
Files 28 28
Lines 2554 2565 +11
==========================================
+ Hits 2248 2259 +11
Misses 306 306 ☔ View full report in Codecov by Sentry. |
4 tasks
OkonSamuel
approved these changes
Mar 17, 2024
There was a problem hiding this comment.
Looks good. This should also resolve JuliaAI/MLJ.jl#1100.
Thanks @ablaom for looking into this.
This was referenced Mar 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A model that supports features importances exposes these via the method
feature_importances. However, these importances are hidden if the model is wrapped inTransformedTargetModelor is part of a pipeline. This PR implementsfeature_importances(and the traitreports_feature_importances) for these two wrappers by forwarding the atomic methods.For testing purposes, the test model
DecisionTreeClassifierin /test/_models/DecisionTree.jl has been updated to support feature importances.@OkonSamuel